Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Tests #13

Merged
merged 11 commits into from
Nov 30, 2024
Merged

fix: Update Tests #13

merged 11 commits into from
Nov 30, 2024

Conversation

jtriley-eth
Copy link
Contributor

Description

Remove tests from impl blocks, dedupe test names.

Additional Context

Tests now fail for msm on Secp256r1, MNT6_753, MNT4_753, and Secp384r1 curves. I'm unsure what msm means, but the error originates in the Curve::evaluate_linear_expression method and fails in __compute_quadratic_expression_with_borrow_flags from the noir-bignum library, specifically:

assert(remainder == [0; N]);

@kashbrti kashbrti changed the title Update Tests fix: Update Tests Nov 28, 2024
@kashbrti kashbrti marked this pull request as ready for review November 28, 2024 14:40
@TomAFrench
Copy link
Member

Looks like the issue is just from trying to run too many tests at once. I've made CI run these single-threaded for now to hopefully unblock this.

@TomAFrench TomAFrench merged commit e1f1c9c into main Nov 30, 2024
5 checks passed
@TomAFrench TomAFrench deleted the jtriley-eth/test-updates branch November 30, 2024 01:06
@github-actions github-actions bot mentioned this pull request Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants